-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add runbook urls for alerts #3452
add runbook urls for alerts #3452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. LGTM, just one small nit on the changelog format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant grouped with the other ENHANCEMENTS. (I might have gotten the line number wrong as you would have deleted the previous line it was on). Hope this makes more sense.
8047432
to
a339454
Compare
@jhesketh I updated the code with suggested changes, and rebased my branch with latest main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry about the run-around. Looks good to me :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Great work. I just have a comment to actually reuse the utility function instead of copy-pasting it.
To fix the linter you can just run |
Co-authored-by: Joshua Hesketh <josh@hesketh.net.au> Update CHANGELOG.md Co-authored-by: Joshua Hesketh <josh@hesketh.net.au>
Co-authored-by: Marco Pracucci <marco@pracucci.com> Add scheme to DNS service discovery docs (grafana#3450) * Add schema to DNS service discovery docs The missing schema leads to errors like `improperly formatted alertmanager URL "alertmanager.mimir.svc.cluster.local:8080/alertmanager" (maybe the scheme is missing?)`. * Update docs/sources/operators-guide/configure/about-dns-service-discovery.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Alertmanager configuration validate-only mode grafana#3437 (grafana#3440) * Alertmanager configuration validate-only mode grafana#3437 * Documentation update for alertmanager config validation * Update changelog * Update docs/sources/operators-guide/architecture/components/alertmanager.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Swap a command line flag for a verify subcommand. * Update pkg/mimirtool/commands/alerts.go Co-authored-by: Marco Pracucci <marco@pracucci.com> * For loop to reduce repetition * Use review suggestion. * Make alertmanager verification docs more consistent. Bump from enhancement to feature. * fmt * Fix the golint issue. * Fix typo * Make doc result (as specified by lint process) Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> lint fix
Head branch was pushed to by a user without write access
bbc50b4
to
abcf3dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* add runbook urls for alerts Co-authored-by: Joshua Hesketh <josh@hesketh.net.au> Update CHANGELOG.md Co-authored-by: Joshua Hesketh <josh@hesketh.net.au> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com> Add scheme to DNS service discovery docs (grafana#3450) * Add schema to DNS service discovery docs The missing schema leads to errors like `improperly formatted alertmanager URL "alertmanager.mimir.svc.cluster.local:8080/alertmanager" (maybe the scheme is missing?)`. * Update docs/sources/operators-guide/configure/about-dns-service-discovery.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Alertmanager configuration validate-only mode grafana#3437 (grafana#3440) * Alertmanager configuration validate-only mode grafana#3437 * Documentation update for alertmanager config validation * Update changelog * Update docs/sources/operators-guide/architecture/components/alertmanager.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Swap a command line flag for a verify subcommand. * Update pkg/mimirtool/commands/alerts.go Co-authored-by: Marco Pracucci <marco@pracucci.com> * For loop to reduce repetition * Use review suggestion. * Make alertmanager verification docs more consistent. Bump from enhancement to feature. * fmt * Fix the golint issue. * Fix typo * Make doc result (as specified by lint process) Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> lint fix Co-authored-by: Joshua Hesketh <josh@hesketh.net.au>
What this PR does
Adds runbook_urls to all the mimir alerts
Which issue(s) this PR fixes or relates to
Fixes #2303
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]