-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default installation namespace on OpenShift #5441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, only some minor changes.
While looking at the PR I came across the --install-mode
which is currently set to OwnNamespace
. Is this still correct when we plan to have the operator running in openshift-operators-redhat
but Loki deployed to openshift-logging
?
@xperimental yeah it works fine when I try to deploy operator in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, something just occurred to me while looking at it the second time: The later instructions in hack_loki_operator.md
still correctly reference the openshift-logging
namespace because we intend to run Loki in that namespace, but the first command referencing the namespace will fail if it does not exist.
Does it make sense to add a paragraph to the doc for creating the namespace before trying to add resources to it? In the document that would be before adding the AWS secret.
openshift-operators-redhat
ns
What this PR does / why we need it:
openshift-operators-redhat
.loki.openshift.io
->loki.grafana.com
Which issue(s) this PR fixes:
Fixes #5440
Special notes for your reviewer:
Checklist
CHANGELOG.md
about the changes.