-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cancel issue between Query Frontend and Query Schdeduler #5113
Merged
cyriltovena
merged 12 commits into
grafana:main
from
kavirajk:fix-scheduler-cancellation-issue
Jan 13, 2022
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7fcab44
Fix cancel issue between Query Frontend -> Query Schdeduler
kavirajk a19b764
remove assert check for message type
kavirajk a97344a
Handle the case where Frontend is running without Frontend workers
kavirajk 3e3e238
Make it into `sendRequestCancel()` func
kavirajk 7e56476
Remove debug logs
kavirajk 68673e4
Fix note
kavirajk e34baf3
Remove workers count debug log on test
kavirajk bd85e7d
Add bug link to test
kavirajk a9e5c67
Fixes the case where we cancel after enqueuing
cyriltovena 72f4fc9
Update pkg/lokifrontend/frontend/v2/frontend.go
cyriltovena 7c433a6
Switch to a buffered channel instead
cyriltovena a6d8ab3
Add error on unknown response status from scheduler
kavirajk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a warning here, or even an error: this shouldn't ever happen and indicates a bug.