Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cancel issue between Query Frontend and Query Schdeduler #5113

Merged
merged 12 commits into from
Jan 13, 2022
Merged

Fix cancel issue between Query Frontend and Query Schdeduler #5113

merged 12 commits into from
Jan 13, 2022

Commits on Jan 12, 2022

  1. Fix cancel issue between Query Frontend -> Query Schdeduler 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    7fcab44 View commit details
    Browse the repository at this point in the history

  2. remove assert check for message type 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    a19b764 View commit details
    Browse the repository at this point in the history

  3. Handle the case where Frontend is running without Frontend workers 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    a97344a View commit details
    Browse the repository at this point in the history

  4. Make it into sendRequestCancel() func 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    3e3e238 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Remove debug logs 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    7e56476 View commit details
    Browse the repository at this point in the history

  2. Fix note 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    68673e4 View commit details
    Browse the repository at this point in the history

  3. Remove workers count debug log on test 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    e34baf3 View commit details
    Browse the repository at this point in the history

  4. Add bug link to test 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    bd85e7d View commit details
    Browse the repository at this point in the history

  5. Fixes the case where we cancel after enqueuing 

    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    a9e5c67 View commit details
    Browse the repository at this point in the history

  6. Update pkg/lokifrontend/frontend/v2/frontend.go 

    Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @cyriltovena @colega
    cyriltovena and colega authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    72f4fc9 View commit details
    Browse the repository at this point in the history

  7. Switch to a buffered channel instead 

    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    7c433a6 View commit details
    Browse the repository at this point in the history

  8. Add error on unknown response status from scheduler 

    Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
    @kavirajk
    kavirajk committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    a6d8ab3 View commit details
    Browse the repository at this point in the history