Test & fix queries return multiple streams. #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
323-stream-labels
branch
2 times, most recently
from
9c39812
to
98b1b55
Compare
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
tomwilkie
force-pushed
the
323-stream-labels
branch
from
98b1b55
to
864fc11
Compare
This was referenced Feb 18, 2019
woodsaj
reviewed
Feb 18, 2019
| _, err = i.Push(ctx, &req) | ||
| require.NoError(t, err) | ||
|
|
||
| fmt.Println("hehe") |
periklis
added a commit
to periklis/loki
that referenced
this pull request
Sep 10, 2024
[release-5.8] Backport PR grafana#13708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My advice to @woodsaj in #308 was completely bogo. Whats more, when doing the multiple-entries-with-same-timestamp work, I conflated entries from different streams.
This fixes and adds tests for them. Fixes #323
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com