Add Aditya CS as a member of Loki. #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2170 +/- ##
=======================================
Coverage 61.23% 61.23%
=======================================
Files 146 146
Lines 11196 11196
=======================================
Hits 6856 6856
Misses 3794 3794
Partials 546 546 |
sandeepsukhani
approved these changes
Jun 4, 2020
docs/community/governance.md
Outdated
| - Sandeep Sukhani [sandeepsukhani](https://github.com/sandeepsukhani) | ||
| - Tom Braack [sh0rez](https://github.com/sh0rez) | ||
| - Tom Wilkie [tomwilkie](https://github.com/tomwilkie) | ||
| - Aditya C S [adityacs](https://github.com/adityacs) |
There was a problem hiding this comment.
Should we add name of the company where Aditya works?
There was a problem hiding this comment.
Cyril had initially added it. I asked him to remove. The thing is, since I work on this project only in my free time, I don't think I am officially allowed to have my company name here.
docs/community/governance.md
Outdated
| - Tom Braack [sh0rez](https://github.com/sh0rez) | ||
| - Tom Wilkie [tomwilkie](https://github.com/tomwilkie) | ||
| - Aditya C S [adityacs](https://github.com/adityacs) | ||
| - Cyril Tovena (Grafana) [cyriltovena](https://github.com/cyriltovena) |
There was a problem hiding this comment.
Should it be Grafana Labs instead of Grafana? I don't have a strong opinion about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com