Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Propose new governance #2137

Merged
merged 6 commits into from
Jun 16, 2020
Merged

[WIP] Propose new governance #2137

merged 6 commits into from
Jun 16, 2020

Conversation

RichiH
Copy link
Member

@RichiH RichiH commented May 26, 2020

This is not yet ready to merge. It serves as a basis for discussion and needs to be voted upon if it were to be accepted & merged.

Signed-off-by: Richard Hartmann <richih@richih.org>
@CLAassistant
Copy link

CLAassistant commented May 26, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #2137 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
+ Coverage   62.02%   62.06%   +0.03%     
==========================================
  Files         156      156              
  Lines       12531    12531              
==========================================
+ Hits         7772     7777       +5     
+ Misses       4149     4145       -4     
+ Partials      610      609       -1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.30% <0.00%> (-0.42%) ⬇️
pkg/promtail/targets/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/querier/queryrange/downstreamer.go 97.93% <0.00%> (+2.06%) ⬆️
pkg/promtail/targets/tailer.go 76.13% <0.00%> (+2.27%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I guess we need more than just me aggreeing.

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RichiH and others added 2 commits June 15, 2020 20:29
Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Richard Hartmann <richih@richih.org>
Signed-off-by: Richard Hartmann <richih@richih.org>
docs/community/governance.md Outdated Show resolved Hide resolved
If the new member proposal is accepted, the proposed team member should be contacted privately via email to confirm or deny their acceptance of team membership. This email will also be CC'd to loki-team@googlegroups.com for record-keeping purposes.
The current team members are:

- Aditya C S - [adityacs](https://github.com/adityacs) ([Grafana Labs](https://grafana.com/))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityacs You're at IBM I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; @sh0rez also pointed this out and also thinks IBM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityacs requested that we didn't list IBM since he works on Loki on his free time, we should probably remove it here too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the governance requires to add the company name, I am OK to get my name removed here. Later I will create a PR to add my name if I get an official approval.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, was not aware. I can remove the name, or put you as independent, whichever you prefer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichiH You don't have to be sorry 😄 . Independent should be fine.
Thanks

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit then LGTM

[announce]: https://groups.google.com/forum/#!forum/loki-announce
[coc]: https://github.com/grafana/loki/blob/master/CODE_OF_CONDUCT.md
[devs]: https://groups.google.com/forum/#!forum/loki-developers
[maintainers]: https://github.com/grafana/loki/blob/master/MAINTAINERS.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist I guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, @slim-bean needs to decide if that's any subsystem maintainers or if he wants to be listed for *.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To start we won't assign any subsystem maintainers, however I expect this to change over time.

I think you are stuck with me for all the things :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALL THE THINGS!!!111

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Richard Hartmann <richih@richih.org>
@RichiH RichiH requested a review from sh0rez June 16, 2020 16:31
@RichiH
Copy link
Member Author

RichiH commented Jun 16, 2020

8 out of 11 people agree, as such supermajority has been reached.

@RichiH RichiH requested review from sh0rez and removed request for davkal, gouthamve and sh0rez June 16, 2020 17:03
@RichiH
Copy link
Member Author

RichiH commented Jun 16, 2020

GitHub is wonky, sorry @sh0rez you will need to LGTM it.

@RichiH RichiH merged commit 0ecaa10 into master Jun 16, 2020
@RichiH RichiH deleted the richih/loki_governance branch June 16, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.