Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions to common.libsonnet for warpstream #14123

Merged

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Sep 12, 2024

What this PR does / why we need it:

This commit adds a number of functions to common.libsonnet so we can use lib/warpstream. These functions are copied from https://github.com/grafana/mimir/blob/main/operations/mimir/common.libsonnet.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner September 12, 2024 10:04
@grobinson-grafana grobinson-grafana self-assigned this Sep 12, 2024
@grobinson-grafana grobinson-grafana changed the title Add functions to common.libsonnet for warpstream task: add functions to common.libsonnet for warpstream Sep 12, 2024
@grobinson-grafana grobinson-grafana changed the title task: add functions to common.libsonnet for warpstream feat: Add functions to common.libsonnet for warpstream Sep 12, 2024
@grobinson-grafana grobinson-grafana changed the title feat: Add functions to common.libsonnet for warpstream feat: add functions to common.libsonnet for warpstream Sep 12, 2024
@grobinson-grafana grobinson-grafana force-pushed the grobinson/update-common-libsonnet-warpstream branch from 272d93c to 5c41893 Compare September 12, 2024 10:08
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grobinson-grafana grobinson-grafana merged commit 2bde071 into main Sep 12, 2024
61 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/update-common-libsonnet-warpstream branch September 12, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants