Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly return http status codes from ingester to querier for RPC function calls #13134

Merged
merged 5 commits into from
Jun 7, 2024
Merged

fix: properly return http status codes from ingester to querier for RPC function calls #13134

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59f5948
return http status codes from ingester
cstyan Jun 4, 2024
a251163
simplify the error wrapping
cstyan Jun 5, 2024
b97e8a6
pass matchers
cstyan Jun 5, 2024
225d24f
fix lint
cstyan Jun 5, 2024
a4cc4e2
remove unintended println
cstyan Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions pkg/ingester/ingester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ import (
"github.com/prometheus/prometheus/model/labels"
"google.golang.org/grpc/health/grpc_health_v1"

server_util "github.com/grafana/loki/v3/pkg/util/server"

"github.com/grafana/loki/v3/pkg/analytics"
"github.com/grafana/loki/v3/pkg/chunkenc"
"github.com/grafana/loki/v3/pkg/distributor/writefailures"
Expand Down Expand Up @@ -1041,6 +1043,13 @@ func (i *Ingester) asyncStoreMaxLookBack() time.Duration {

// GetChunkIDs is meant to be used only when using an async store like boltdb-shipper or tsdb.
func (i *Ingester) GetChunkIDs(ctx context.Context, req *logproto.GetChunkIDsRequest) (*logproto.GetChunkIDsResponse, error) {
gcr, err := i.getChunkIDs(ctx, req)
err = server_util.ClientGrpcStatusAndError(err)
return gcr, err
}

// GetChunkIDs is meant to be used only when using an async store like boltdb-shipper or tsdb.
func (i *Ingester) getChunkIDs(ctx context.Context, req *logproto.GetChunkIDsRequest) (*logproto.GetChunkIDsResponse, error) {
orgID, err := tenant.TenantID(ctx)
if err != nil {
return nil, err
Expand Down Expand Up @@ -1111,21 +1120,28 @@ func (i *Ingester) Label(ctx context.Context, req *logproto.LabelRequest) (*logp
pprof.Do(ctx, pprof.Labels("path", "read", "type", "labels", "tenant", userID), func(c context.Context) {
resp, err = instance.Label(ctx, req, matchers...)
if err != nil {
fmt.Println("error: ", err)
cstyan marked this conversation as resolved.
Show resolved Hide resolved
return
}
if req.Start == nil {
fmt.Println("asdf")
cstyan marked this conversation as resolved.
Show resolved Hide resolved

return
}

// Only continue if the active index type is one of async index store types or QueryStore flag is true.
asyncStoreMaxLookBack := i.asyncStoreMaxLookBack()
if asyncStoreMaxLookBack == 0 && !i.cfg.QueryStore {
fmt.Println("qwer")
cstyan marked this conversation as resolved.
Show resolved Hide resolved

return
}

var cs storage.Store
var ok bool
if cs, ok = i.store.(storage.Store); !ok {
fmt.Println("1234")
cstyan marked this conversation as resolved.
Show resolved Hide resolved

return
}

Expand All @@ -1137,18 +1153,24 @@ func (i *Ingester) Label(ctx context.Context, req *logproto.LabelRequest) (*logp
start := adjustQueryStartTime(maxLookBackPeriod, *req.Start, time.Now())
if start.After(*req.End) {
// The request is older than we are allowed to query the store, just return what we have.
fmt.Println("ttttt")
cstyan marked this conversation as resolved.
Show resolved Hide resolved

return
}
from, through := model.TimeFromUnixNano(start.UnixNano()), model.TimeFromUnixNano(req.End.UnixNano())

if req.Values {
storeValues, err = cs.LabelValuesForMetricName(ctx, userID, from, through, "logs", req.Name, matchers...)
if err != nil {
fmt.Println("error2: ", err)
cstyan marked this conversation as resolved.
Show resolved Hide resolved

return
}
} else {
storeValues, err = cs.LabelNamesForMetricName(ctx, userID, from, through, "logs", matchers...)
if err != nil {
fmt.Println("error3: ", err)
cstyan marked this conversation as resolved.
Show resolved Hide resolved

return
}
}
Expand All @@ -1160,6 +1182,7 @@ func (i *Ingester) Label(ctx context.Context, req *logproto.LabelRequest) (*logp
if err != nil {
return nil, err
}
fmt.Println("resp values: ", resp.Values)
cstyan marked this conversation as resolved.
Show resolved Hide resolved

return &logproto.LabelResponse{
Values: util.MergeStringLists(resp.Values, storeValues),
Expand All @@ -1168,6 +1191,12 @@ func (i *Ingester) Label(ctx context.Context, req *logproto.LabelRequest) (*logp

// Series queries the ingester for log stream identifiers (label sets) matching a set of matchers
func (i *Ingester) Series(ctx context.Context, req *logproto.SeriesRequest) (*logproto.SeriesResponse, error) {
sr, err := i.series(ctx, req)
err = server_util.ClientGrpcStatusAndError(err)
return sr, err
}

func (i *Ingester) series(ctx context.Context, req *logproto.SeriesRequest) (*logproto.SeriesResponse, error) {
instanceID, err := tenant.TenantID(ctx)
if err != nil {
return nil, err
Expand Down Expand Up @@ -1331,6 +1360,11 @@ func (i *Ingester) getInstances() []*instance {

// Tail logs matching given query
func (i *Ingester) Tail(req *logproto.TailRequest, queryServer logproto.Querier_TailServer) error {
err := i.tail(req, queryServer)
err = server_util.ClientGrpcStatusAndError(err)
return err
}
func (i *Ingester) tail(req *logproto.TailRequest, queryServer logproto.Querier_TailServer) error {
select {
case <-i.tailersQuit:
return errors.New("Ingester is stopping")
Expand Down Expand Up @@ -1376,6 +1410,12 @@ func (i *Ingester) Tail(req *logproto.TailRequest, queryServer logproto.Querier_

// TailersCount returns count of active tail requests from a user
func (i *Ingester) TailersCount(ctx context.Context, _ *logproto.TailersCountRequest) (*logproto.TailersCountResponse, error) {
tcr, err := i.tailersCount(ctx)
err = server_util.ClientGrpcStatusAndError(err)
return tcr, err
}

func (i *Ingester) tailersCount(ctx context.Context) (*logproto.TailersCountResponse, error) {
instanceID, err := tenant.TenantID(ctx)
if err != nil {
return nil, err
Expand Down Expand Up @@ -1431,6 +1471,12 @@ func (i *Ingester) GetDetectedFields(_ context.Context, r *logproto.DetectedFiel

// GetDetectedLabels returns map of detected labels and unique values from this ingester
func (i *Ingester) GetDetectedLabels(ctx context.Context, req *logproto.DetectedLabelsRequest) (*logproto.LabelToValuesResponse, error) {
lvr, err := i.getDetectedLabels(ctx, req)
err = server_util.ClientGrpcStatusAndError(err)
return lvr, err
}

func (i *Ingester) getDetectedLabels(ctx context.Context, req *logproto.DetectedLabelsRequest) (*logproto.LabelToValuesResponse, error) {
userID, err := tenant.TenantID(ctx)
if err != nil {
return nil, err
Expand Down
31 changes: 31 additions & 0 deletions pkg/ingester/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ import (
"github.com/grafana/loki/v3/pkg/util/deletion"
util_log "github.com/grafana/loki/v3/pkg/util/log"
mathutil "github.com/grafana/loki/v3/pkg/util/math"
server_util "github.com/grafana/loki/v3/pkg/util/server"
"github.com/grafana/loki/v3/pkg/validation"
)

Expand Down Expand Up @@ -441,6 +442,12 @@ func (i *instance) getLabelsFromFingerprint(fp model.Fingerprint) labels.Labels
}

func (i *instance) Query(ctx context.Context, req logql.SelectLogParams) (iter.EntryIterator, error) {
it, err := i.query(ctx, req)
err = server_util.ClientGrpcStatusAndError(err)
return it, err
}

func (i *instance) query(ctx context.Context, req logql.SelectLogParams) (iter.EntryIterator, error) {
expr, err := req.LogSelector()
if err != nil {
return nil, err
Expand Down Expand Up @@ -495,6 +502,12 @@ func (i *instance) Query(ctx context.Context, req logql.SelectLogParams) (iter.E
}

func (i *instance) QuerySample(ctx context.Context, req logql.SelectSampleParams) (iter.SampleIterator, error) {
it, err := i.querySample(ctx, req)
err = server_util.ClientGrpcStatusAndError(err)
return it, err
}

func (i *instance) querySample(ctx context.Context, req logql.SelectSampleParams) (iter.SampleIterator, error) {
expr, err := req.Expr()
if err != nil {
return nil, err
Expand Down Expand Up @@ -556,6 +569,12 @@ func (i *instance) QuerySample(ctx context.Context, req logql.SelectSampleParams
// If label matchers are given only the matching streams are fetched from the index.
// The label names or values are then retrieved from those matching streams.
func (i *instance) Label(ctx context.Context, req *logproto.LabelRequest, matchers ...*labels.Matcher) (*logproto.LabelResponse, error) {
lr, err := i.label(ctx, req, matchers...)
err = server_util.ClientGrpcStatusAndError(err)
return lr, err
}

func (i *instance) label(ctx context.Context, req *logproto.LabelRequest, matchers ...*labels.Matcher) (*logproto.LabelResponse, error) {
if len(matchers) == 0 {
var labels []string
if req.Values {
Expand Down Expand Up @@ -709,6 +728,12 @@ func (i *instance) Series(ctx context.Context, req *logproto.SeriesRequest) (*lo
}

func (i *instance) GetStats(ctx context.Context, req *logproto.IndexStatsRequest) (*logproto.IndexStatsResponse, error) {
isr, err := i.getStats(ctx, req)
err = server_util.ClientGrpcStatusAndError(err)
return isr, err
}

func (i *instance) getStats(ctx context.Context, req *logproto.IndexStatsRequest) (*logproto.IndexStatsResponse, error) {
matchers, err := syntax.ParseMatchers(req.Matchers, true)
if err != nil {
return nil, err
Expand Down Expand Up @@ -765,6 +790,12 @@ func (i *instance) GetStats(ctx context.Context, req *logproto.IndexStatsRequest
}

func (i *instance) GetVolume(ctx context.Context, req *logproto.VolumeRequest) (*logproto.VolumeResponse, error) {
vr, err := i.getVolume(ctx, req)
err = server_util.ClientGrpcStatusAndError(err)
return vr, err
}

func (i *instance) getVolume(ctx context.Context, req *logproto.VolumeRequest) (*logproto.VolumeResponse, error) {
matchers, err := syntax.ParseMatchers(req.Matchers, true)
if err != nil && req.Matchers != seriesvolume.MatchAny {
return nil, err
Expand Down
9 changes: 9 additions & 0 deletions pkg/util/server/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ const (
ErrDeadlineExceeded = "Request timed out, decrease the duration of the request or add more label matchers (prefer exact match over regex match) to reduce the amount of data processed."
)

func ClientGrpcStatusAndError(err error) error {
if err == nil {
return nil
}

status, newErr := ClientHTTPStatusAndError(err)
return httpgrpc.Errorf(status, "%s", newErr.Error())
}

// WriteError write a go error with the correct status code.
func WriteError(err error, w http.ResponseWriter) {
status, cerr := ClientHTTPStatusAndError(err)
Expand Down
Loading