refactor(blooms): Add RPC service for bloom-planner #13015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
approved these changes
May 27, 2024
pkg/bloombuild/planner/metrics.go
Outdated
| taskLost: promauto.With(r).NewCounter(prometheus.CounterOpts{ | ||
| Namespace: metricsNamespace, | ||
| Subsystem: metricsSubsystem, | ||
| Name: "task_lost_total", |
There was a problem hiding this comment.
Shouldn't this be named tasks_lost_total?
| if err := services.StartManagerAndAwaitHealthy(ctx, p.subservices); err != nil { | ||
| return fmt.Errorf("error starting planner subservices: %w", err) | ||
| } | ||
|
|
||
| p.metrics.running.Set(1) |
There was a problem hiding this comment.
nit: How meaningful is the running metric?
There was a problem hiding this comment.
We use it for other components and in the original bloom compactor.
Even though you may use a k82 metric to check if the pod is running:
- That won't work in non- k82 envs
- This is set to 1 only when the component is actually ready to start working
So I think that's the usefulness of this metric.
pkg/bloombuild/planner/planner.go
Outdated
Comment on lines
150
to
152
| p.pendingTasksMu.Lock() | ||
| inflight := len(p.pendingTasks) | ||
| p.pendingTasksMu.Unlock() |
There was a problem hiding this comment.
nit: Since we use this pendingTasks every time we use the queue, would it make sense to implement a reusable sync map for pending tasks?
Comment on lines
384
to
395
| // Start planner | ||
| err = planner.StartAsync(context.Background()) | ||
| require.NoError(t, err) | ||
| require.Eventually(t, func() bool { | ||
| return planner.State() == services.Running | ||
| }, 15*time.Second, 10*time.Millisecond) | ||
| defer func() { | ||
| planner.StopAsync() | ||
| require.Eventually(t, func() bool { | ||
| return planner.State() != services.Running | ||
| }, 1*time.Minute, 100*time.Millisecond) | ||
| }() |
There was a problem hiding this comment.
You can use functions from the services package for starting and stopping:
err := services.StartAndAwaitRunning(context.Background(), planner)
require.NoError(t, err)
t.Cleanup(func() {
err := services.StopAndAwaitTerminated(context.Background(), planner)
require.NoError(t, err)
})There was a problem hiding this comment.
Oh nice, TIL! Thank you 👍
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new RPC service implemented by the planner to communicate the planner and the builder. The implementation is pretty similar top the query scheduler.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR