docs: Don't allow running new and old querier worker grpc clients #12916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
DylanGuedes
changed the title
MichelHollands
approved these changes
May 8, 2024
docs/sources/shared/configuration.md
Outdated
| @@ -2237,19 +2237,19 @@ The `frontend_worker` configures the worker - running within the Loki querier - | |||
| [id: <string> | default = ""] | |||
|
|
|||
| # Configures the querier gRPC client used to communicate with the | |||
| # query-frontend. Shouldn't be used in conjunction with 'grpc_client_config'. | |||
| # query-frontend. Can't be used in conjunction with 'grpc_client_config'. | |||
There was a problem hiding this comment.
(nit) I prefer full sentences:
Suggested change
| # query-frontend. Can't be used in conjunction with 'grpc_client_config'. | |
| # query-frontend. This can't be used in conjunction with 'grpc_client_config'. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make new and old ways of configuring querier workers grpc clients mutually exclusive. Otherwise we'll never migrate to the new configs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR