Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update template_functions.md #12841

Merged
merged 1 commit into from
May 2, 2024
Merged

docs: Update template_functions.md #12841

merged 1 commit into from
May 2, 2024

Conversation

doanbutar
Copy link
Contributor

".err" & "ErrTimeout" seem to be reversed leading to incorrect results

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

".err" & "ErrTimeout" seem to be reversed leading to incorrect results
@doanbutar doanbutar requested a review from a team as a code owner May 1, 2024 02:57
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label May 1, 2024
Copy link
Contributor

@salvacorts salvacorts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

{{ if contains "he" "hello" }} yes {{end}}
```

## eq

Use this function to test to see if one string has exact matching inside of another.

Signature: `eq(s string, src string) bool`
Signature: `eq(src string, s string) bool`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it doesn't really matter for eq but it's fine to change it.

@salvacorts salvacorts changed the title Update template_functions.md docs: Update template_functions.md May 2, 2024
@salvacorts salvacorts merged commit ed84b23 into main May 2, 2024
61 checks passed
@salvacorts salvacorts deleted the doanbutar-patch-3 branch May 2, 2024 08:37
ystkfujii pushed a commit to ystkfujii/loki that referenced this pull request May 3, 2024
grafanabot pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants