Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix function names #12817

Merged
merged 1 commit into from
May 9, 2024
Merged

style: fix function names #12817

merged 1 commit into from
May 9, 2024

Conversation

MarkDaveny
Copy link
Contributor

@MarkDaveny MarkDaveny commented Apr 29, 2024

What this PR does / why we need it:

fix function names

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: MarkDaveny <peicuiping@aliyun.com>
@MarkDaveny MarkDaveny requested a review from a team as a code owner April 29, 2024 12:32
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024

CLA assistant check
All committers have signed the CLA.

@MarkDaveny
Copy link
Contributor Author

If anything need I to do, Please feel free to tell me.

@paul1r paul1r changed the title pkg: fix function names style: fix function names May 9, 2024
@paul1r
Copy link
Collaborator

paul1r commented May 9, 2024

lgtm! I just changed the PR title to be style: to fit with the conventional commit format. Thanks for the contribution!

@paul1r paul1r merged commit 3a46d37 into grafana:main May 9, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants