Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add info about step param for Patterns API #12803

Merged
merged 1 commit into from
Apr 29, 2024
Merged

docs: Add info about step param for Patterns API #12803

merged 1 commit into from
Apr 29, 2024

Conversation

benclive
Copy link
Contributor

What this PR does / why we need it:
Adds some documentation for the new step parameter added to the patterns API.

Which issue(s) this PR fixes:
Additional docs for #12689

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@benclive benclive requested a review from a team as a code owner April 26, 2024 11:06
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 26, 2024
JStickler
JStickler approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@JStickler JStickler merged commit 74db5dd into main Apr 29, 2024
61 checks passed
@JStickler JStickler deleted the add-patterns-api-step-to-docs branch April 29, 2024 18:43
shantanualsi pushed a commit that referenced this pull request May 6, 2024
@benclive @shantanualsi
docs: Add info about step param for Patterns API (#12803)
dba220c
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benclive @grafanabot @JStickler