ci: release workflows get build image from makefile #12778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Apr 24, 2024
trevorwhitney
force-pushed
the
gh-actions-build-image
branch
from
bcb66c3
to
93eb83a
Compare
github-actions
bot
added
the
type/docs
trevorwhitney
added a commit
to JStickler/loki
that referenced
this pull request
May 1, 2024
(cherry picked from commit af09f53)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Provide the build image version as an external variable to the release workflows jsonnet so it matches the version as defined in the Makefile (which is what we do for drone).