Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing Helm helper loki.hpa.apiVersion #12755

Merged

Conversation

mattgialelis
Copy link
Contributor

@mattgialelis mattgialelis commented Apr 23, 2024

What this PR does / why we need it:
Currently the 6.3.3 and 6.2.2. helm charts when trying to enable the Horizontal Pod Autoscaler for the Distributed deployment type fails due to the missing loki.hpa.apiVersion which is required for the the Helm chart to template/install making it un-useable for large scale deployments with the need for autoscaling

Error that is fixed by this PR

Error:

template: loki/templates/query-frontend/hpa.yaml:3:19: executing "loki/templates/query-frontend/hpa.yaml" at <include "loki.hpa.apiVersion" .>: error calling include: template: no template "loki.hpa.apiVersion" associated with template "gotpl"

Which issue(s) this PR fixes:

Fixes #12716

Special notes for your reviewer:

Had to recreate this pr, the rebase i did on my fork broke the last branch and PR, sry

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@mattgialelis
Copy link
Contributor Author

Any update on how i can get this merged in ? Is sadly stopping me from moving to loki 3.0 and away from the loki-distributed helm chart

@mattgialelis
Copy link
Contributor Author

@JStickler Any ideas on the process to get his merged in please :)

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichelHollands MichelHollands merged commit 3070ea7 into grafana:main Apr 30, 2024
61 checks passed
shantanualsi pushed a commit that referenced this pull request May 6, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing "loki/templates/query-frontend/hpa.yaml" at <include "loki.hpa.apiVersion" .>: error calling includ
3 participants