Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Data race updates for memchunk tests #12752

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Apr 23, 2024

What this PR does / why we need it:
Multiple instances of a data race related to the noopStreamPipeline variable. This was resolved by creating a new one per test, as opposed to sharing a single instance between all tests.

After updates:

go test -race -count=1 .   -v -timeout 0
PASS
ok  	github.com/grafana/loki/v3/pkg/chunkenc	776.725s

Which issue(s) this PR fixes:
Relates to #8586

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner April 23, 2024 12:31
@paul1r paul1r merged commit c178cc6 into main Apr 23, 2024
57 checks passed
@paul1r paul1r deleted the paul1r/memchunk_test_data_races branch April 23, 2024 12:40
mattgialelis pushed a commit to mattgialelis/loki that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants