Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Azure example configuration snippets #12725

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Apr 22, 2024

What this PR does / why we need it:
Adds configuration snippets related to Azure to the examples.

Which issue(s) this PR fixes:
Fixes #8301

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner April 22, 2024 12:46
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 22, 2024
@paul1r paul1r changed the title doc: Add Azure example configuration snippets docs: Add Azure example configuration snippets Apr 22, 2024
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] couple of suggestions to clean up the comments.

paul1r and others added 3 commits April 22, 2024 11:27
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM.

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@paul1r paul1r merged commit afb4b60 into main Apr 22, 2024
17 checks passed
@paul1r paul1r deleted the paul1r/azure_config_example_issue_8301 branch April 22, 2024 20:26
@grafanabot
Copy link
Collaborator

The backport to release-2.9.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-12725-to-release-2.9.x origin/release-2.9.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x afb4b604cd8f908d013f1741d3c7a07dd103dc63

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-12725-to-release-2.9.x
# Create the PR body template
PR_BODY=$(gh pr view 12725 --json body --template 'Backport afb4b604cd8f908d013f1741d3c7a07dd103dc63 from #12725{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "chore: [release-2.9.x] docs: Add Azure example configuration snippets" --body-file - --label "size/M" --label "type/docs" --label "backport" --base release-2.9.x --milestone release-2.9.x --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-12725-to-release-2.9.x

# Create a pull request where the `base` branch is `release-2.9.x` and the `compare`/`head` branch is `backport-12725-to-release-2.9.x`.

# Remove the local backport branch
git switch main
git branch -D backport-12725-to-release-2.9.x

grafanabot pushed a commit that referenced this pull request Apr 22, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
(cherry picked from commit afb4b60)
mattgialelis pushed a commit to mattgialelis/loki that referenced this pull request Apr 23, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
JStickler pushed a commit that referenced this pull request Apr 23, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
(cherry picked from commit afb4b60)
JStickler added a commit that referenced this pull request Apr 24, 2024
Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.9.x backport release-3.0.x backport-failed size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Requesting examples for Azure Storage
3 participants