Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ingester zoneAwareReplication #12659

Merged
merged 5 commits into from
Apr 19, 2024
Merged

fix: Ingester zoneAwareReplication #12659

merged 5 commits into from
Apr 19, 2024

Conversation

hendrikkiedrowski
Copy link
Contributor

There were some typos in the ingester helm templates

@hendrikkiedrowski hendrikkiedrowski requested a review from a team as a code owner April 17, 2024 16:55
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JStickler JStickler changed the title Bugfix: Ingester zoneAwareReplication fix: Ingester zoneAwareReplication Apr 17, 2024
MichelHollands and others added 2 commits April 19, 2024 16:19
@MichelHollands
Merge branch 'main' into main
f1a6f41
@MichelHollands
Update README as well
4dc536d 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
MichelHollands
MichelHollands approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hendrikkiedrowski
Copy link
Contributor Author

In the meantime the version already changed shall i update PR to reflect that? @MichelHollands

@MichelHollands
Copy link
Contributor

In the meantime the version already changed shall i update PR to reflect that? @MichelHollands

@hendrikkiedrowski Thanks for this fix. I've already updated the version so that should be fine to go.

@hendrikkiedrowski
Copy link
Contributor Author

Long day. Sorry didn't see that.

@MichelHollands MichelHollands merged commit 9edb0ce into grafana:main Apr 19, 2024
16 checks passed
This was referenced Apr 22, 2024
Closed
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 9, 2024
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@hendrikkiedrowski @JStickler @MichelHollands
fix: Ingester zoneAwareReplication (grafana#12659)
bddd44f 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Co-authored-by: Michel Hollands <michel.hollands@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hendrikkiedrowski @CLAassistant @MichelHollands @JStickler