Skip to content

Commit

Permalink
test: gcs object client test data race (#12324)
Browse files Browse the repository at this point in the history
  • Loading branch information
paul1r authored Mar 27, 2024
1 parent bdad1d3 commit aca2a38
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/storage/chunk/client/gcp/gcs_object_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,7 @@ func gcsTransport(ctx context.Context, scope string, insecure bool, http2 bool,
transportOptions := []option.ClientOption{option.WithScopes(scope)}
if insecure {
customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
// When using `insecure` (testing only), we add a fake API key as well to skip credential chain lookups.
transportOptions = append(transportOptions, option.WithAPIKey("insecure"))
transportOptions = append(transportOptions, option.WithoutAuthentication())
}
if serviceAccount.String() != "" {
transportOptions = append(transportOptions, option.WithCredentialsJSON([]byte(serviceAccount.String())))
Expand Down

0 comments on commit aca2a38

Please sign in to comment.