[promtail] support multiple clients via clients
#1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dungdm93
changed the title
clientConfigsclientConfigs
dungdm93
changed the title
clientConfigsclients
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
trevorwhitney
approved these changes
Jun 1, 2022
|
I guess https://github.com/grafana/helm-charts/blob/main/charts/promtail/README.md.gotmpl#L155-L156 should have been adjusted as well, shouldn't they? |
bors-openebs-mayastor bot
pushed a commit
to openebs/mayastor-extensions
that referenced
this pull request
Dec 27, 2023
398: fix(chart): promtail subchart changes for chart v6.13.1 r=niladrih a=niladrih The `lokiAddress` key is no longer useful with the new loki-stack helm chart. Clients are not input into the `clients[]` array. Ref: grafana/helm-charts#1425 Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1214
cc @trevorwhitney