Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable wrapper-validation by default in setup-gradle #318

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented Jul 31, 2024

No description provided.

By slurping the checksum URLs from https://services.gradle.org/distributions-snapshots/
we can include these unpublished wrapper checksums in validation.

Fixes #281
@bigdaz bigdaz force-pushed the dd/snapshot-wrapper-checksums branch 2 times, most recently from a6997f7 to 4ee7c4c Compare August 1, 2024 04:03
- Add 'allow-snapshot-wrappers' input parameter
- Default 'validate-wrappers' to 'true'

Fixes #12
The most common case for validation will be that the wrapper jars are unchanged
from a previous workflow run. In this case, we cache the validated wrapper
checksums to minimise the work required on a subsequent run.

Fixes #172
@bigdaz bigdaz force-pushed the dd/snapshot-wrapper-checksums branch from 9334ab3 to 2e52c98 Compare August 1, 2024 16:58
@bigdaz bigdaz force-pushed the dd/snapshot-wrapper-checksums branch from 2e52c98 to 73f1290 Compare August 1, 2024 16:59
@bigdaz bigdaz changed the title Include wrapper checksums for Gradle nightlies and other snapshots Enable wrapper-validation by default in setup-gradle Aug 1, 2024
@bigdaz bigdaz merged commit 06905c7 into main Aug 1, 2024
3 checks passed
@bigdaz bigdaz deleted the dd/snapshot-wrapper-checksums branch August 1, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant