Fix multimodal textbox custom components #8719
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/bc749dd498052185b9ac288171a06509ae5d879c/gradio-4.37.2-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@bc749dd498052185b9ac288171a06509ae5d879c#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/bc749dd498052185b9ac288171a06509ae5d879c/gradio-client-1.2.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Thanks @freddyaboulton! Could we add a test to ensure that all of our core components can be used as templates for custom components? Would be helpful as we add new components (e.g. TimeRange) |
|
Modified the tests @abidlabs ! Thanks for the suggestion |
test/test_gradio_component_cli.py
Outdated
| """When you add a new component this test will likely fail locally | ||
| because the js files have not been moved to the _frontend_code directory. | ||
|
|
||
| Just build the python package to move the latest state of the js directory to _frontend_code. |
There was a problem hiding this comment.
What does "build the python package" mean? Do you mean build the frontend?
There was a problem hiding this comment.
Need to build the wheel so that a script to copy the js files gets run. Let me update comment!
There was a problem hiding this comment.
lgtm thanks for updating the test @freddyaboulton! just one question above
freddyaboulton
force-pushed
the
multimodal_textbox-cc
branch
from
60fa6c8
to
bc749dd
Compare
Description
Closes: #8718
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh