Bind fetch and stream in JS client
#8714
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/1a44bb554f7d4a8402640167fb1b950df6ebab82/gradio-4.37.2-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@1a44bb554f7d4a8402640167fb1b950df6ebab82#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/1a44bb554f7d4a8402640167fb1b950df6ebab82/gradio-client-1.2.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Hmm. The deployed demos work fine, not sure why those tests are failing. |
|
Thanks @hannahblair! Can we add a test for this? I'm surprised that this wasn't already caught by our E2E tests |
|
Yeah I don't really understand how this didn't cause our functional tests to fail. |
|
Although now it is hilariously. |
js/upload/src/UploadProgress.svelte
Outdated
| @@ -59,6 +60,7 @@ | |||
| }; | |||
| }); | |||
| onDestroy(() => { | |||
| // the stream will close itself but is here for perspicuity; remove .close() in 5.0 | |||
There was a problem hiding this comment.
are ppl just making words up or something
There was a problem hiding this comment.
maybe i'm just stupider than i thought i was (and i already thought i was pretty stupid)
There was a problem hiding this comment.
i did consult a thesaurus and it was exactly the word i needed 😤
There was a problem hiding this comment.
see cambridge dictionarys definition
There was a problem hiding this comment.
i need a new word
There was a problem hiding this comment.
right fine clarity it is
There was a problem hiding this comment.
Perfect, thanks! And thanks for figuring out that test failure @hannahblair!
Description
Bind
fetchandstreamin the JS client as these methods have nothisvalue when called outside the client.Thanks to @pngwn for spotting the issue + solution!
Closes: #8707
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh