Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds trigger_mode to gr.on. Use it to set trigger_model="always_last" for live interfaces. #7794

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Mar 22, 2024

Description

Closes: #7752

You can test it here: https://huggingface.co/spaces/freddyaboulton/fast-typing-live-bug

Should not drop any text like the video in the original issue

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@freddyaboulton freddyaboulton added the v: patch A change that requires a patch release label Mar 22, 2024
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 22, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/9f78884a5f04b9027d924022b9915136b8c7459b/gradio-4.22.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9f78884a5f04b9027d924022b9915136b8c7459b#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Adds trigger_mode to gr.on. Use it to set trigger_model="always_last" for live interfaces.

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Ah beautiful, thanks for fixing @freddyaboulton!

@abidlabs
Copy link
Member

Let me merge this in since we have a lot of open PRs right now

@abidlabs abidlabs merged commit cf98c7e into main Mar 22, 2024
7 checks passed
@abidlabs abidlabs deleted the 7752-always-last-live-interfaces branch March 22, 2024 23:00
@pngwn pngwn mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Real time applications (input trigger or live=True) fail on finishing sentences
3 participants