-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gr.load()
so that it works with the SSE v1 protocol
#6810
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/40f68f9464d880c07e458c2cb865402828edaab5/gradio-4.9.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@40f68f9464d880c07e458c2cb865402828edaab5#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
helper = None | ||
if endpoint.protocol in ("ws", "sse"): | ||
helper = client.new_helper(fn_index) | ||
helper = client.new_helper(fn_index) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I had added "sse_v1" to the list but actually I don't think there's any reason to have this check because gr.load()
only works with gradio==4.x
which includes the protocol anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense
gr.load()
so that it works with the SSE v1 protocol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abidlabs !
Thanks @freddyaboulton for the quick review! |
Stupidly simple fix 🥲
Fixes: #5927