Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue 5781: Enables specifying a caching directory for Examples #6803

Merged
merged 13 commits into from
Dec 19, 2023

Conversation

cswamy
Copy link
Contributor

@cswamy cswamy commented Dec 15, 2023

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #5781

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 15, 2023

🪼 branch checks and previews

Name Status URL
🦄 Changes detected! Details

@cswamy
Copy link
Contributor Author

cswamy commented Dec 15, 2023

Looks like there are some formatting errors. Will check and fix.

gradio/helpers.py Outdated Show resolved Hide resolved
@abidlabs
Copy link
Member

Thanks @cswamy! I made a couple of suggestions, otherwise looks good.

Could we also add a test for this, here:

class TestExamples:

cswamy and others added 3 commits December 17, 2023 12:29
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
@cswamy
Copy link
Contributor Author

cswamy commented Dec 18, 2023

@abidlabs added 2 tests. Please check.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 18, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fixes issue 5781: Enables specifying a caching directory for Examples

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Refactored the tests a bit but otherwise looks good! Thanks @cswamy, will merge this in once the tests pass

@abidlabs abidlabs merged commit 77c9003 into gradio-app:main Dec 19, 2023
7 of 15 checks passed
@pngwn pngwn mentioned this pull request Dec 19, 2023
whitphx pushed a commit that referenced this pull request Dec 20, 2023
…#6803)

* issue 5781 first commit

* second commit

* unnecessary str removed

* backend formatted

* Update gradio/helpers.py

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* Update guides/02_building-interfaces/03_more-on-examples.md

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* tests added

* add changeset

* format

---------

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify Example Caching Directory
3 participants