Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend tests on Windows #6781

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Fix backend tests on Windows #6781

merged 7 commits into from
Dec 14, 2023

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Dec 13, 2023

2 non-flaky tests were failing on Windows. Turns out one was a problem with the test, while the other was actually an issue in the code. Both should be fixed now.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 13, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/97cd3139fa22d3616e80eeda30fce68cfb74239d/gradio-4.9.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@97cd3139fa22d3616e80eeda30fce68cfb74239d#subdirectory=client/python"

@abidlabs abidlabs added the windows-tests Run backend tests on Windows on this PR (by default, applied only to the changeset release PR) label Dec 13, 2023
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 13, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix backend tests on Windows

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs changed the title make windows tests pass Fix backend tests on Windows Dec 14, 2023
@abidlabs abidlabs marked this pull request as ready for review December 14, 2023 07:20
@abidlabs abidlabs added the v: patch A change that requires a patch release label Dec 14, 2023
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @abidlabs !

@abidlabs
Copy link
Member Author

Thanks @freddyaboulton

@abidlabs abidlabs merged commit a807ede into main Dec 14, 2023
21 checks passed
@abidlabs abidlabs deleted the windows-tests branch December 14, 2023 19:23
@pngwn pngwn mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release windows-tests Run backend tests on Windows on this PR (by default, applied only to the changeset release PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants