-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve source selection UX #6766
Merged
Merged
Changes from 2 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
6615151
Add new source option styling for pasting from clipboard
hannahblair 08a0416
prevent device selection cut off
hannahblair f99fa3a
Check for dupe sources in source selection
hannahblair 5ec31b8
tweaks
hannahblair 60dc45e
tweak
hannahblair 9756b35
add image interaction test
hannahblair d6c1e93
more tests
hannahblair 838a16f
improve light/dark mode color contrast
hannahblair 352f714
Merge branch 'main' into improve-source-selection
hannahblair 9feb0cc
add changeset
gradio-pr-bot dc1526f
remove unused prop
hannahblair 8681c41
Merge branch 'improve-source-selection' of github.com:gradio-app/grad…
hannahblair b0be967
add no device found placeholder
hannahblair 94f2d51
style tweak
hannahblair 8bbc7ed
Merge branch 'main' into improve-source-selection
hannahblair 5d24f01
allow pasting on click + add e2e test
hannahblair 8e7426d
Merge branch 'improve-source-selection' of github.com:gradio-app/grad…
hannahblair d5dec81
Merge branch 'main' into improve-source-selection
hannahblair e44d909
Merge branch 'main' into improve-source-selection
hannahblair c9ed31a
Merge branch 'improve-source-selection' of github.com:gradio-app/grad…
hannahblair bf95184
Merge branch 'main' into improve-source-selection
hannahblair 0397497
fix e2e tests
hannahblair 3cdad9e
Merge branch 'improve-source-selection' of github.com:gradio-app/grad…
hannahblair a823d4f
formatting
hannahblair 216b9e9
Merge branch 'main' into improve-source-selection
hannahblair c6689d0
add timeout to e2e test
hannahblair b8c695a
Merge branch 'improve-source-selection' of github.com:gradio-app/grad…
hannahblair 81ca4a4
tweak
hannahblair e64cf2b
tweak test
hannahblair f28633e
change `getByLabel` to `getByText`
hannahblair 87d3b61
value tweak
hannahblair 7f75408
logic tweak
hannahblair 59a64da
test
hannahblair b6d8f54
formatting
hannahblair 1a98513
Merge branch 'main' into improve-source-selection
hannahblair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the use of Partial here and throughout this file? I don't believe it makes a difference in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also would name the type differently if we also have a variable called sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial is needed because the
SelectSource
is used in Video, Audio and Image andsources[]
isn't the same for them all - e.g.microphone
isn't used by Image