Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editable parameter to Audio #6745

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Conversation

hannahblair
Copy link
Collaborator

Description

We removed the show_edit_button because editing was no longer done via an edit button in the component (currently done via a trim button), and we therefore allowed all interactive elements to be editable. That said, preventing users from editing audio still has its use cases. This PR adds the functionality back in, via an editable param. In theory, this just means users can't use the trimming functionality, but naming this editable creates space for any further editing functionality we may add in future.

Closes: #5128 (again 😅)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 11, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/bd1e30458dc4d46ce218af1617747adc3977b754/gradio-4.8.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@bd1e30458dc4d46ce218af1617747adc3977b754#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 11, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/audio minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add editable parameter to Audio

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to get rid of the "Reset Audio" button? I don't think it does anything if the component is not editable. Otherwise looks great!

image

@hannahblair
Copy link
Collaborator Author

I think we also need to get rid of the "Reset Audio" button? I don't think it does anything if the component is not editable. Otherwise looks great!

image

Oh of course! Thanks for catching that @freddyaboulton.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @hannahblair !

@hannahblair hannahblair merged commit 3240d04 into main Dec 11, 2023
22 checks passed
@hannahblair hannahblair deleted the add-editable-param-to-audio branch December 11, 2023 17:42
@pngwn pngwn mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose option to allow/forbid users to edit audio
3 participants