modify preprocess to use pydantic models #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.pyInstall Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/07fb02725147b1a7b0e52236b7a44d929adcf053/gradio-4.0.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@07fb02725147b1a7b0e52236b7a44d929adcf053#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Merged
| @@ -1260,6 +1260,14 @@ def preprocess_data( | |||
| inputs_cached = processing_utils.move_files_to_cache( | |||
| inputs[i], block | |||
| ) | |||
| if getattr(block, "data_model", None) and inputs_cached is not None: | |||
| if issubclass(block.data_model, GradioModel): # type: ignore | |||
| print("block.data_model", block.data_model, block) | |||
There was a problem hiding this comment.
Can we get rid of the print statements?
There was a problem hiding this comment.
Oops I'll do it on @dawoodkhan82's branch, thanks for catching
There was a problem hiding this comment.
Let me know if you find anything else! I merged this just now so that we could have everything in place and do another release
pngwn
pushed a commit
that referenced
this pull request
Nov 3, 2023
* modify preprocess to use pydantic models * changes * add changeset * fix * fix * fix typing * save * revert queuing changes * fix * fix * notebook * fix * changes * add changeset * fix functional tests --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part II of #6176