This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename function is added. Usage added to pkg/main.go and README Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
- Loading branch information
Showing
4 changed files
with
119 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package kvs | ||
|
||
import "errors" | ||
|
||
// Rename changes the name of the key. It deletes the old key-value pair. If the | ||
// new key already exists, renaming cannot be done. | ||
func (k *Kvs) Rename(key string, newKey string) (bool, error) { | ||
k.mu.Lock() | ||
defer k.mu.Unlock() | ||
|
||
if k.Exists(newKey) { | ||
return false, errors.New("new key is already exists") | ||
} | ||
|
||
k.kv[newKey] = k.kv[key] | ||
k.Del(key) | ||
return true, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
package kvs | ||
|
||
import ( | ||
"os" | ||
"testing" | ||
"time" | ||
) | ||
|
||
func TestKvs_Rename(t *testing.T) { | ||
db, err := open(t.Name(), "", 2*time.Minute) | ||
if err != nil { | ||
t.Fatalf(err.Error()) | ||
} | ||
t.Logf("db created.") | ||
|
||
k, v := "foo", "bar" | ||
db.Set(k, v) | ||
t.Logf("Key-value pair is set.") | ||
t.Logf("%s: %s", k, v) | ||
|
||
ok, err := db.Rename(k, k+k) | ||
if err != nil { | ||
t.Errorf(err.Error()) | ||
} | ||
if !ok { | ||
t.Errorf("key didn't change") | ||
} else { | ||
t.Logf("key renamed.") | ||
} | ||
|
||
val := db.Get(k) | ||
if val != "" { | ||
t.Errorf("%s-%s pair is still exits.", k, val) | ||
} | ||
t.Logf("%s-%s", k, val) | ||
|
||
val = db.Get(k + k) | ||
if val != v { | ||
t.Errorf("expected %s-%s pair, but got %s-%s", k+k, v, k+k, val) | ||
} | ||
t.Logf("%s-%s", k+k, val) | ||
|
||
err = db.Close() | ||
if err != nil { | ||
t.Fatalf(err.Error()) | ||
} | ||
t.Logf("db closed.") | ||
|
||
err = os.RemoveAll(db.dir) | ||
if err != nil { | ||
t.Fatalf(err.Error()) | ||
} | ||
t.Logf("temp db removed.") | ||
} | ||
|
||
func TestKvs_RenameExistsNewKey(t *testing.T) { | ||
db, err := open(t.Name(), "", 2*time.Minute) | ||
if err != nil { | ||
t.Fatalf(err.Error()) | ||
} | ||
t.Logf("db created.") | ||
|
||
k, v := "foo", "bar" | ||
db.Set(k, v) | ||
t.Logf("Key-value pair is set.") | ||
t.Logf("%s: %s", k, v) | ||
|
||
ok, err := db.Rename(k, k) | ||
if !ok { | ||
t.Logf("key didn't change") | ||
} | ||
|
||
val := db.Get(k) | ||
if val != v { | ||
t.Errorf("%s-%s pair is wrong.", k, val) | ||
} | ||
|
||
err = db.Close() | ||
if err != nil { | ||
t.Fatalf(err.Error()) | ||
} | ||
t.Logf("db closed.") | ||
|
||
err = os.RemoveAll(db.dir) | ||
if err != nil { | ||
t.Fatalf(err.Error()) | ||
} | ||
t.Logf("temp db removed.") | ||
} |