Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed method StreamPlayer.getPositionByte() #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HelgeStenstrom
Copy link
Collaborator

Description

The method was used in a unit test, as a means to
test the StreamPlayer.seekTo() method, but it never
worked. The StreamPlayer.getPositionByte() didn't seem
to work.

There are no other callers of getPositionByte() method in this codebase.
It is not used by XR3Player. It seems safe to remove it.

If the method really worked (which I doubt), then this is a
non-backwards-compatible change.

This change is a part of an effort to make all unit tests pass, by either updating the production code, the tests, or remove the failing tests.

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update
  • Refactor
  • Build-related changes
  • This change requires a documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes, if the removed method actually works and is used.
  • No

Has This Been Tested?

  • Yes
  • No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

The method was used in a unit test, as a means to
test the StreamPlayer.seekTo() method, but it never
worked. The StreamPlayer.getPositionByte() didn't seem
to work.

There are no other callers of getPositionByte() method in this codebase.
It is not used by XR3Player. It seems safe to remove it.

If the method really worked (which I doubt), then this is a
non-backwards-compatible change.

This change is a part of an effort to make all unit tests pass, by either updating the production code, the tests, or remove the failing tests.
@goxr3plus
Copy link
Owner

@HelgeStenstrom I will have a good look on this because these days i will update XR3Player to use our latest java-stream-player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants