-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-assignment of audioInputStream removed #57
base: master
Are you sure you want to change the base?
Re-assignment of audioInputStream removed #57
Commits on Dec 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 719d370 - Browse repository at this point
Copy the full SHA 719d370View commit details -
Update StreamPlayerMethodsTest.java
Some unit tests are improved, but there are more to be done.
Configuration menu - View commit details
-
Copy full SHA for 0ef3d2f - Browse repository at this point
Copy the full SHA 0ef3d2fView commit details
Commits on Dec 19, 2019
-
Re-assignment of audioInputStream removed by changing audioInputStream = AudioSystem.getAudioInputStream(targetFormat, audioInputStream); to assignment of a new variable. Variable name changes: Initial audioInputStream changed to encodedAudioInputStream audioInputStream after the re-assignment now assigned to a field called decodedAudioInputStream. Old encodedAudioInputStream renamed to encodedAudioInputStreamCopy.
Configuration menu - View commit details
-
Copy full SHA for 611b279 - Browse repository at this point
Copy the full SHA 611b279View commit details -
Configuration menu - View commit details
-
Copy full SHA for afb30bc - Browse repository at this point
Copy the full SHA afb30bcView commit details -
encodedAudioInputStream doesn't change, so it doesn't have to be vola…
…tile. According to Sonar, Non-primitive fields should not be "volatile" For primitive fields volatile inhibits caching. This is only of interest of the field changes value, but this one doesn't. Since the field is an object reference, value change in this context means that it gets replaced with a different object, but it will not happen. See also https://wiki.sei.cmu.edu/confluence/display/java/CON50-J.+Do+not+assume+that+declaring+a+reference+volatile+guarantees+safe+publication+of+the+members+of+the+referenced+object
Configuration menu - View commit details
-
Copy full SHA for 357eacf - Browse repository at this point
Copy the full SHA 357eacfView commit details
Commits on Dec 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 68c67ca - Browse repository at this point
Copy the full SHA 68c67caView commit details
Commits on Dec 22, 2019
-
Improved and more complete unit tests.
StreamPlayerMethodsTest still contains tests that don't pass. The tested methods are candidates for removal from StreamPlayer. All tests in StreamPlayerMethodsTest must be reviewed: Do they actually verify anything that need to be verified? Or are they too coupled with the current implementation? StreamPlayerFutureImprovementTest contains tests that currently fail. Failures are caused by behavior in StreamPlayer which I think is wrong or bad. But I may have misinterpreted the intended behavior.
Configuration menu - View commit details
-
Copy full SHA for dca8c7a - Browse repository at this point
Copy the full SHA dca8c7aView commit details -
Merge pull request goxr3plus#59 from HelgeStenstrom/improveUnitTesting
Improve unit testing
Configuration menu - View commit details
-
Copy full SHA for 2905d6e - Browse repository at this point
Copy the full SHA 2905d6eView commit details
Commits on Dec 31, 2019
-
Merge pull request goxr3plus#56 from HelgeStenstrom/removeNullChecks
AudioSystem.getMixerInfo() will not return null, so we don't have to …
Configuration menu - View commit details
-
Copy full SHA for 7f08cff - Browse repository at this point
Copy the full SHA 7f08cffView commit details
Commits on Jan 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8463821 - Browse repository at this point
Copy the full SHA 8463821View commit details
Commits on Feb 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 074a81b - Browse repository at this point
Copy the full SHA 074a81bView commit details
Commits on Mar 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1ec869b - Browse repository at this point
Copy the full SHA 1ec869bView commit details -
Re-assignment of audioInputStream removed by changing audioInputStream = AudioSystem.getAudioInputStream(targetFormat, audioInputStream); to assignment of a new variable. Variable name changes: Initial audioInputStream changed to encodedAudioInputStream audioInputStream after the re-assignment now assigned to a field called decodedAudioInputStream. Old encodedAudioInputStream renamed to encodedAudioInputStreamCopy.
Configuration menu - View commit details
-
Copy full SHA for 2cb8475 - Browse repository at this point
Copy the full SHA 2cb8475View commit details -
encodedAudioInputStream doesn't change, so it doesn't have to be vola…
…tile. According to Sonar, Non-primitive fields should not be "volatile" For primitive fields volatile inhibits caching. This is only of interest of the field changes value, but this one doesn't. Since the field is an object reference, value change in this context means that it gets replaced with a different object, but it will not happen. See also https://wiki.sei.cmu.edu/confluence/display/java/CON50-J.+Do+not+assume+that+declaring+a+reference+volatile+guarantees+safe+publication+of+the+members+of+the+referenced+object
Configuration menu - View commit details
-
Copy full SHA for d91395b - Browse repository at this point
Copy the full SHA d91395bView commit details -
Merge branch 'decodedAudioInputStream' of https://github.com/HelgeSte…
…nstrom/java-stream-player into decodedAudioInputStream
Configuration menu - View commit details
-
Copy full SHA for ef87e06 - Browse repository at this point
Copy the full SHA ef87e06View commit details