Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUT-2143 - Upgrade to GOV.UK Frontend v5 #2128

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gtvj
Copy link
Collaborator

@gtvj gtvj commented Oct 3, 2024

Caution

Do not merge this PR until the rest of the programme is ready to upgrade. GOV.UK Frontend v5 introduces visual changes so it needs to be a coordinated upgrade

What

Upgrades GOV.UK Frontend to v5 and updates the codebase accordingly. Specific changes include:

  1. Updating package file paths for client-side JavaScript, Nunjucks, Sass, images and fonts to reflect the new package organisation
  2. Updating our client-side JavaScript approach to reflect changes
  3. Addressing Sass deprecation warnings introduced by the upgrade
  4. Removing IE Conditional comments (v5 "removes support completely for Internet Explorer 8-10")
  5. Changing the case for the phase within translation files because v5 removes the CSS text-transform we had relied on
  6. Replacing our custom password component (which was based on GOV.UK Publishing Components prior to them adopting the Design System component with the Design System component

Visual changes introduced in v5

  • changes to the ‘Tag’ component (this is present in the phase banner)
  • enabling link styles introduced in v3.12.0 by default
  • the password input component from the Design System

How to review

  1. Code review
  2. Running the branch locally or in a deployed environment, run through the following journeys to verify that pages are rendering correctly and password components continue to function as expected:
    a. Account creation (including triggering a validation error on the password creation page)
    b. Sign in (including triggering a validation error on the password entry page)
    c. Try to create a new account using an existing email address (and trigger a error on the password entry page)
    d. Forgot password (including triggering an error on the new password creation page)

Checklist

  • Performance analyst has been notified of the change.
  • A UCD review has been performed.
  • Any necessary changes to the acceptance tests
  • Documentation has been updated to reflect these changes.

Related PRs

@gtvj gtvj requested review from a team as code owners October 3, 2024 15:14
@gtvj gtvj force-pushed the AUT-2143/upgrade-to-govuk-frontend-v5 branch 2 times, most recently from 893b1e5 to 6ad280b Compare October 3, 2024 15:40
Fixes Sass deprecation warnings specific to the GOV.UK Frontend
API since upgrade to version 5.x
The upgrade to GOV.UK Frontend v5 removes the CSS text transform
applied to the phase name in the phase banner. This commit introduces
the correct case in the translation files.
These comments were to improve support for very old versions of
Internet Explorer but, more importantly, the referenced resources
do not exist.
@gtvj gtvj force-pushed the AUT-2143/upgrade-to-govuk-frontend-v5 branch from 6ad280b to 4ea1edb Compare October 3, 2024 16:00
Replaces our custom password input Nunjucks macro with the
Design System component.
@gtvj gtvj force-pushed the AUT-2143/upgrade-to-govuk-frontend-v5 branch from 4ea1edb to d17fe75 Compare October 3, 2024 16:40
Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant