-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUT-2143 - Upgrade to GOV.UK Frontend v5 #2128
Open
gtvj
wants to merge
9
commits into
main
Choose a base branch
from
AUT-2143/upgrade-to-govuk-frontend-v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was achieved via `yarn upgrade govuk-frontend@latest`
Updates reflect instructions provided on the release page at: https://github.com/alphagov/govuk-frontend/releases/tag/v5.0.0
gtvj
force-pushed
the
AUT-2143/upgrade-to-govuk-frontend-v5
branch
2 times, most recently
from
October 3, 2024 15:40
893b1e5
to
6ad280b
Compare
Fixes Sass deprecation warnings specific to the GOV.UK Frontend API since upgrade to version 5.x
The upgrade to GOV.UK Frontend v5 removes the CSS text transform applied to the phase name in the phase banner. This commit introduces the correct case in the translation files.
These comments were to improve support for very old versions of Internet Explorer but, more importantly, the referenced resources do not exist.
gtvj
force-pushed
the
AUT-2143/upgrade-to-govuk-frontend-v5
branch
from
October 3, 2024 16:00
6ad280b
to
4ea1edb
Compare
Replaces our custom password input Nunjucks macro with the Design System component.
gtvj
force-pushed
the
AUT-2143/upgrade-to-govuk-frontend-v5
branch
from
October 3, 2024 16:40
4ea1edb
to
d17fe75
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this PR until the rest of the programme is ready to upgrade. GOV.UK Frontend v5 introduces visual changes so it needs to be a coordinated upgrade
What
Upgrades GOV.UK Frontend to v5 and updates the codebase accordingly. Specific changes include:
text-transform
we had relied onVisual changes introduced in v5
How to review
a. Account creation (including triggering a validation error on the password creation page)
b. Sign in (including triggering a validation error on the password entry page)
c. Try to create a new account using an existing email address (and trigger a error on the password entry page)
d. Forgot password (including triggering an error on the new password creation page)
Checklist
Related PRs