Add the password input component #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
password-input-component
branch
from
2d041da
to
8f1a5bd
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
8f1a5bd
to
de1f763
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
de1f763
to
0e5e546
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
0e5e546
to
eb60fc8
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
eb60fc8
to
5b98fc9
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
5b98fc9
to
d8e90b1
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
d8e90b1
to
31765a1
Compare
andysellick
reviewed
Sep 3, 2024
|
|
||
| label_text ||= t("components.password_input.label") | ||
|
|
||
| # This overrides the 'Show/Hide' button text, but this button text is getting overwritten by GOVUK Frontend JS currently when you interact with the button. Therefore this functionality is not being exposed in the docs. |
There was a problem hiding this comment.
Worth asking the Design System team if it's possible/planned to be able to override the text values in https://github.com/alphagov/govuk-frontend/blob/main/packages/govuk-frontend/src/govuk/components/password-input/password-input.mjs#L222-L231
There was a problem hiding this comment.
@andysellick It looks possible, so I'll implement it tomorrow 👍 https://gds.slack.com/archives/CAF8JA25U/p1725376708644069?thread_ts=1725374973.976699&cid=CAF8JA25U
app/views/govuk_publishing_components/components/_password_input.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_password_input.html.erb
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_password_input.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_password_input.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/docs/password_input.yml
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/docs/password_input.yml
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_password_input.html.erb
Show resolved
Hide resolved
AshGDS
force-pushed
the
password-input-component
branch
from
ea67340
to
57636c4
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
57636c4
to
6f14bc6
Compare
|
Thanks for reviewing @andysellick 👍 I've made every change requested, so this should be ready for another review. |
andysellick
reviewed
Sep 4, 2024
| it "renders a password input component correctly by default" do | ||
| render_component({}) | ||
| puts rendered |
andysellick
approved these changes
Sep 4, 2024
AshGDS
force-pushed
the
password-input-component
branch
from
6f14bc6
to
398f4f7
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
398f4f7
to
1fa5ef5
Compare
AshGDS
force-pushed
the
password-input-component
branch
from
1fa5ef5
to
eacb157
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Show/Hidebutton text to be overwritten. However, the button text gets changed by the GOVUK Frontend JavaScript on click. Therefore even if we change the text in the HTML, it gets overwritten as soon as you click the button. Therefore I've added the ability to change the button text in the template file, but I haven't made it known in theymldocs that it's a feature.Visual Changes