Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

support forwardref as linkComponent #907

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

svict4
Copy link

@svict4 svict4 commented Jun 7, 2020

When trying to use Link from Gatsby instead of a normal <a> tag, we get a bunch of propType warnings and pain.
This is because it is exported (from @reach/router) as a forwardRef, rather than a string or function.

I've updated to use the new PropTypes.elementType over PropType.func
See facebook/prop-types#211

Where there are type checks for 'function', I've replaced them with react-is isValidElementType() - but only where it relates to linkComponent

sukhrajghuman and others added 8 commits August 28, 2019 14:13
Minor restructure to use GitHub documentation standards
…ges/animate/handlebars-4.5.3

Bump handlebars from 4.1.2 to 4.5.3 in /packages/animate
…ebars-4.5.3

Bump handlebars from 4.1.2 to 4.5.3
@svict4 svict4 marked this pull request as ready for review June 25, 2020 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants