-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add last seen field to client (fixes #400) #582
Conversation
b7c3643
to
2142833
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 85.97% 85.76% -0.21%
==========================================
Files 45 45
Lines 1590 1616 +26
==========================================
+ Hits 1367 1386 +19
- Misses 140 145 +5
- Partials 83 85 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see another PR from you (:
7c110b5
to
ead566d
Compare
Thanks for the review, its been some time since I was active here. Yeah I should have read #400 more carefully you are correct we are discussing more about token last used instead of client alive-or-not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I've also extracted the ui code for the last used cell to a separate file.
This PR fixes #400 by adding a last seen field to the client model. The last seen field is updated on connection & every pong response.