Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): fix index out of range caused by duplicate labels #700

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

zhenghaoz
Copy link
Collaborator

No description provided.

@zhenghaoz zhenghaoz added the backport release-0.4 Backport to release-0.4 label Jun 4, 2023
@zhenghaoz zhenghaoz linked an issue Jun 4, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (a668b05) 69.89% compared to head (9ce4ba2) 69.87%.

❗ Current head 9ce4ba2 differs from pull request most recent head e7af2cb. Consider uploading reports for the commit e7af2cb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
- Coverage   69.89%   69.87%   -0.03%     
==========================================
  Files          63       63              
  Lines       11967    11969       +2     
==========================================
- Hits         8364     8363       -1     
- Misses       2827     2828       +1     
- Partials      776      778       +2     
Impacted Files Coverage Δ
master/tasks.go 58.80% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhenghaoz zhenghaoz merged commit 9ff8a6c into master Jun 4, 2023
@zhenghaoz zhenghaoz deleted the fix_neg_idf branch June 4, 2023 05:34
@gorse-io gorse-io deleted a comment from github-actions bot Jun 4, 2023
@zhenghaoz
Copy link
Collaborator Author

/backport

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Backport failed for release-0.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-0.4
git worktree add -d .worktree/backport-700-to-release-0.4 origin/release-0.4
cd .worktree/backport-700-to-release-0.4
git checkout -b backport-700-to-release-0.4
ancref=$(git merge-base a668b053205b9ccd503e4d3919a9eb36bb90fe98 e7af2cb8b002e4a06c1d5a4a231666ff6713ea01)
git cherry-pick -x $ancref..e7af2cb8b002e4a06c1d5a4a231666ff6713ea01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-0.4 Backport to release-0.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: runtime error: index out of range [207] with length 206
1 participant