Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ClickHouse support #648

Merged
merged 3 commits into from
Mar 17, 2023
Merged

remove ClickHouse support #648

merged 3 commits into from
Mar 17, 2023

Conversation

zhenghaoz
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.29 ⚠️

Comparison is base (53b0c99) 70.60% compared to head (047cb66) 70.32%.

❗ Current head 047cb66 differs from pull request most recent head 0a351df. Consider uploading reports for the commit 0a351df to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   70.60%   70.32%   -0.29%     
==========================================
  Files          63       63              
  Lines       12460    12316     -144     
==========================================
- Hits         8798     8661     -137     
- Misses       2829     2831       +2     
+ Partials      833      824       -9     
Impacted Files Coverage Δ
config/config.go 71.62% <ø> (-0.24%) ⬇️
storage/data/database.go 55.28% <ø> (-0.28%) ⬇️
storage/data/mongodb.go 80.76% <ø> (-0.08%) ⬇️
storage/data/no_database.go 100.00% <ø> (ø)
storage/data/redis.go 70.34% <ø> (-0.15%) ⬇️
storage/data/sql.go 76.19% <90.00%> (-1.88%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhenghaoz zhenghaoz merged commit b20691a into master Mar 17, 2023
@zhenghaoz zhenghaoz deleted the remove_clickhouse branch March 17, 2023 13:21
@flymedllva
Copy link

@zhenghaoz why?
At the same time, there are a lot of references to the clickhouse and benchmarks on the site in all the documentation....

@zhenghaoz
Copy link
Collaborator Author

@zhenghaoz why? At the same time, there are a lot of references to the clickhouse and benchmarks on the site in all the documentation....

ClickHouse is not suitable for lots of point query. The document corresponds for 0.4.x and there will be no clickhouse in 0.5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants