Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Windows log file sink #621

Merged
merged 2 commits into from
Feb 5, 2023
Merged

support Windows log file sink #621

merged 2 commits into from
Feb 5, 2023

Conversation

zhangzhenghao
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 70.67% // Head: 70.62% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (0bda7ae) compared to base (d4aedad).
Patch coverage: 18.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   70.67%   70.62%   -0.05%     
==========================================
  Files          63       63              
  Lines       12425    12435      +10     
==========================================
+ Hits         8781     8782       +1     
- Misses       2810     2817       +7     
- Partials      834      836       +2     
Impacted Files Coverage Δ
base/log/log.go 63.07% <18.18%> (-9.66%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhenghaoz zhenghaoz merged commit 89fc6bc into master Feb 5, 2023
@zhenghaoz zhenghaoz deleted the windows branch February 5, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants