add CORS to rest server and config #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
- Coverage 71.42% 71.21% -0.22%
==========================================
Files 62 62
Lines 11659 11765 +106
==========================================
+ Hits 8327 8378 +51
- Misses 2543 2585 +42
- Partials 789 802 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zhenghaoz
requested changes
Sep 2, 2022
|
thanks for your input. i hope my changes works for you. |
zhenghaoz
requested changes
Sep 5, 2022
thanks for your response. maybe a little bit change is needed 😃 |
|
no problem i learn a lot in go now ^^ |
zhenghaoz
approved these changes
Sep 5, 2022
1003n40
reviewed
Dec 30, 2022
| zap.String("url", fmt.Sprintf("http://%s:%d", s.HttpHost, s.HttpPort))) | ||
| zap.String("url", fmt.Sprintf("http://%s:%d", s.HttpHost, s.HttpPort)), | ||
| zap.Strings("cors_methods", s.Config.Master.HttpCorsMethods), | ||
| zap.Strings("cors_doamins", s.Config.Master.HttpCorsDomains), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have to add it because my frontend gave me some CORS errors. Feel free for some tests and let me know if i have something to change.