Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: converted all internal state/memoized variables to reanimated shared values. #430

Merged
merged 2 commits into from
May 7, 2021

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented May 6, 2021

#427

Motivation

I have refactored the library to use shared values to store and update layout values.

Notice

Calculating snap points position had change in this branch, now the library will count the handle height when positioning the sheet. This is a breaking change and will require developers to carefully monitor the change.

This is how you can visualise it:

snap-point-calculation

Installation

yarn add ssh://git@github.com:gorhom/react-native-bottom-sheet#refactor/convert-variables-to-shared-values

@gorhom gorhom added the v4 Written in Reanimated v2 label May 6, 2021
@gorhom gorhom merged commit 89098e9 into v4 May 7, 2021
@gorhom gorhom deleted the refactor/convert-variables-to-shared-values branch May 7, 2021 19:10
@tambadiya
Copy link

Hello @gorhom stack navigator in bootomsheet and I have different action button to all stack navigator screen so can I use BottomSheetFooter only in stack navigator child screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Written in Reanimated v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants