Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent closing when sheet is out of screen #322

Merged
merged 1 commit into from
Mar 4, 2021
Merged

fix: prevent closing when sheet is out of screen #322

merged 1 commit into from
Mar 4, 2021

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Mar 4, 2021

Closes #321

Motivation

when user add 0 to snap points and then try to close sheet, it won't reset isClosing that will prevent all other events.

Installation

yarn add ssh://git@github.com:gorhom/react-native-bottom-sheet#fix/prevent-closing-when-sheet-is-out-of-screen

@gorhom gorhom added the v2 Written in Reanimated v1 label Mar 4, 2021
@gorhom
Copy link
Owner Author

gorhom commented Mar 4, 2021

@zpv could you test this pr 👍

@zpv
Copy link

zpv commented Mar 4, 2021

@gorhom Looks like this fixed it! Thanks ✌️

@gorhom gorhom merged commit 0aa88ad into master Mar 4, 2021
@gorhom gorhom deleted the fix/prevent-closing-when-sheet-is-out-of-screen branch March 4, 2021 14:33
@carissacks carissacks mentioned this pull request Jun 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v2 Written in Reanimated v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

While a sheet with default backdrop is closing and spam clicking the backdrop, snapTo no longer works.
2 participants
@gorhom @zpv