Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I setup my snap points using percentages,
["0%", "10%", "60%"]
but got an error sayingThis is because the invariant uses the result of the
Number
constructor on the part before the percentage sign - which returns0
here which is falsey.This is easily fixed by using the number
0
rather than the string percentage but it took me a minute or two to realise I could mix numbers and % as my head was in 'percentage mode', so I thought a PR to allow"0%"
might save someone else a few minutes of their time. This PR checksNumber.isNaN
on the output of theNumber
constructor which allows for 0 and any other legitimate number.