Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent modal crash when navigating #244

Merged
merged 3 commits into from
Jan 29, 2021

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Jan 28, 2021

close #240

Motivation

to provide better handling when unmounting due to navigation change.

screencap-2021-01-28T224703.878Z.mp4

Installation

yarn add ssh://git@github.com:gorhom/react-native-bottom-sheet#fix/prevent-modal-crash-when-navigating

@gorhom gorhom added v2 Written in Reanimated v1 modal Related to BottomSheetModal labels Jan 28, 2021
@gorhom gorhom marked this pull request as ready for review January 28, 2021 22:54
@gorhom
Copy link
Owner Author

gorhom commented Jan 28, 2021

@alessiocancian could you please test this pr :)

@gorhom gorhom mentioned this pull request Jan 29, 2021
@alessiocancian
Copy link

@gorhom I'm testing it and it seems to be fixed

@gorhom gorhom merged commit 2f713b6 into master Jan 29, 2021
@gorhom gorhom deleted the fix/prevent-modal-crash-when-navigating branch January 29, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modal Related to BottomSheetModal v2 Written in Reanimated v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BottomSheetModalProvider crashing in some circumstances when dismissing a modal
2 participants