fix: removed disableIntervalMomentum animated value (#13)

gorhom · Aug 13, 2020 · ca0d8cd · ca0d8cd
1 parent 787cf8a
commit ca0d8cd
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 24 deletions.
diff --git a/src/components/bottomSheet/BottomSheet.tsx b/src/components/bottomSheet/BottomSheet.tsx
@@ -211,7 +211,6 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
     /**
      * Scrollable animated props.
      */
-    const disableIntervalMomentum = greaterThan(position, 0);
     const decelerationRate = cond(greaterThan(position, 0), 0.001, 0.999);
     //#endregion
 
@@ -299,7 +298,6 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
         contentPanGestureTranslationY,
         contentPanGestureVelocityY,
         scrollableContentOffsetY,
-        disableIntervalMomentum,
         decelerationRate,
         setScrollableRef: handleSettingScrollableRef,
         removeScrollableRef,

diff --git a/src/components/flatList/FlatList.tsx b/src/components/flatList/FlatList.tsx
@@ -43,11 +43,7 @@ const BottomSheetFlatListComponent = forwardRef(
       handleScrollEvent,
       handleSettingScrollable,
     } = useScrollableInternal('FlatList');
-    const {
-      rootTapGestureRef,
-      disableIntervalMomentum,
-      decelerationRate,
-    } = useBottomSheetInternal();
+    const { rootTapGestureRef, decelerationRate } = useBottomSheetInternal();
 
     // effects
     // @ts-ignore
@@ -70,8 +66,6 @@ const BottomSheetFlatListComponent = forwardRef(
             ref={scrollableRef}
             overScrollMode="never"
             bounces={false}
-            // @ts-ignore
-            disableIntervalMomentum={disableIntervalMomentum}
             decelerationRate={decelerationRate}
             scrollEventThrottle={1}
             onScrollBeginDrag={handleScrollEvent}

diff --git a/src/components/scrollView/ScrollView.tsx b/src/components/scrollView/ScrollView.tsx
@@ -48,11 +48,7 @@ const BottomSheetScrollViewComponent = forwardRef(
       handleScrollEvent,
       handleSettingScrollable,
     } = useScrollableInternal('ScrollView');
-    const {
-      rootTapGestureRef,
-      disableIntervalMomentum,
-      decelerationRate,
-    } = useBottomSheetInternal();
+    const { rootTapGestureRef, decelerationRate } = useBottomSheetInternal();
 
     // effects
     // @ts-ignore
@@ -73,8 +69,6 @@ const BottomSheetScrollViewComponent = forwardRef(
             ref={scrollableRef}
             overScrollMode="never"
             bounces={false}
-            // @ts-ignore
-            disableIntervalMomentum={disableIntervalMomentum}
             decelerationRate={decelerationRate}
             scrollEventThrottle={1}
             onScrollBeginDrag={handleScrollEvent}

diff --git a/src/components/sectionList/SectionList.tsx b/src/components/sectionList/SectionList.tsx
@@ -43,11 +43,7 @@ const BottomSheetSectionListComponent = forwardRef(
       handleScrollEvent,
       handleSettingScrollable,
     } = useScrollableInternal('SectionList');
-    const {
-      rootTapGestureRef,
-      disableIntervalMomentum,
-      decelerationRate,
-    } = useBottomSheetInternal();
+    const { rootTapGestureRef, decelerationRate } = useBottomSheetInternal();
     // effects
     // @ts-ignore
     useImperativeHandle(ref, () => scrollableRef.current!.getNode());
@@ -69,8 +65,6 @@ const BottomSheetSectionListComponent = forwardRef(
             ref={scrollableRef}
             overScrollMode="never"
             bounces={false}
-            // @ts-ignore
-            disableIntervalMomentum={disableIntervalMomentum}
             decelerationRate={decelerationRate}
             scrollEventThrottle={1}
             onScrollBeginDrag={handleScrollEvent}

diff --git a/src/contexts/internal.ts b/src/contexts/internal.ts
@@ -9,7 +9,6 @@ export type BottomSheetInternalContextType = {
   contentPanGestureTranslationY: Animated.Value<number>;
   contentPanGestureVelocityY: Animated.Value<number>;
   scrollableContentOffsetY: Animated.Value<number>;
-  disableIntervalMomentum: Animated.Node<number>;
   decelerationRate: Animated.Node<number>;
   setScrollableRef: (ref: ScrollableRef) => void;
   removeScrollableRef: (ref: RefObject<Scrollable>) => void;