Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group policy templates to aid configuring in Chrome, Edge, and Firefox on Windows #3865

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

theaquamarine
Copy link

Group policy administrative templates describe settings and the UI for configuring them for administrators using Group Policy on Windows computers, and to a lesser extent serve as documentation for the registry settings used. This PR adds a template, and an English language file using descriptions of settings and examples from the wiki, to configure uBlock in Chrome, Edge, and Firefox.

The folder location seemed sensible since the files would not need to be deployed with the application, more likely an admin would download them from github to import and use, so please say if there's a preferable one.

The change to storage.js to allow truth-y values for disableDashboard is intentional - without this, it's more complicated to configure disableDashboard via the registry for Firefox (the other browsers don't need this), and would prevent using a simple enable/disable policy. If needed, this could be removed or moved to a separate PR.

Policies for all available managed storage settings, documentation from
the wiki, and usage examples.
I've not been able to make the other, new settings work.
Firefox preferences appear to not work because of
uBlockOrigin/uBlock-issues#2067
Make configuring via Windows registry easier. Specifically after 1 =
true and 0 = false as booleans are usually stored as dwords, so could
alternatively cast to boolean if typeof disableDashboard === 'number'
@Spacey67
Copy link

Spacey67 commented Apr 4, 2022

Kind of hard to do, tried to do it with Malwarebytes for my org, but it would like trying to set Advanced Driver settings, Definitely would love to make it possible

@gorhill
Copy link
Owner

gorhill commented Apr 5, 2022

I don't think this should be committed to the code base, this should be added to the wiki. Also, it does not feel right to change uBO's code base to accommodate some scenarios very specific to one OS. How more complicated would it be to configure disableDashboard in that one scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants