Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when editing Dynamic URL rules in My Rules tab #475

Closed
harshanvn opened this issue Jul 10, 2015 · 13 comments
Closed

Issue when editing Dynamic URL rules in My Rules tab #475

harshanvn opened this issue Jul 10, 2015 · 13 comments

Comments

@harshanvn
Copy link

STR

  1. Open uBlock Settings window, and save the below rule (i.e., click commit) in My Rules tab
    * http://ajax.aspnetcdn.com/ajax script noop
  2. Click edit button, and remove http:// from above rule
  3. Click save button after removing above part from the rule.
  4. You will see that new rule is not created. Only a temporary entry created to remove the old rule. New rule is altogether missing
Config

uBlock v0.9.9.4 dev7 - FF 39.0 - W7

ublock rule creation missin

@g3939434
Copy link

WIKI - Dynamic URL filtering

destination URL is URL to match: the URL of a resource must start exactly with the destination URL of a rule for a match to occur.

@harshanvn
Copy link
Author

thanks, i missed that.
I some how wondering, it works similarly to dynamic filtering, except that you could create more granular request based type rules...

@harshanvn
Copy link
Author

Ok, I have another question, reg. Dynamic URL Filtering rules.
Whether the requests allowed by URL filtering rules reflect the dynamic Filtering UI (mini Matrix). Right now it is not. Is this expected?

ublock url filtering in ui

@g3939434
Copy link

Whether the requests allowed by URL filtering rules reflect the dynamic Filtering UI (mini Matrix). Right now it is not. Is this expected?

No.

I suggest you should reopen the issue and change the topic, reporting this issue.
Noop rules of Dynamic URL filtering count as blocked on Dynamic filtering pane.

Edit: Maybe open a new issue

@harshanvn
Copy link
Author

Ok Thanks. Submitted #476

@gorhill
Copy link
Owner

gorhill commented Jul 10, 2015

Whether the requests allowed by URL filtering rules reflect the dynamic Filtering UI (mini Matrix). Right now it is not. Is this expected?

Yes it is expected: dynamic URL rules can't be represented in the mini-matrix, as this mini-matrix is entirely based on hostnames. This is just impossible to represent in there: two URL rules can contradict each other for the same cell, plus other intractable UI issues as consequences of trying to reflect URL rules in the matrix.

See it as if trying to fit a square shape into a circle receptacle.

Bottom line: the UI for dynamic URL rules is the logger, or the rule editor.

@harshanvn
Copy link
Author

two URL rules can contradict each other for the same cell

Not exactly sure. Is it not feasible, to count number of requests allowed/blocked and assign it to the cell
Say
a.com/ - block rule based on dynamic filtering setting
a.com/url - allow rule based on dynamic url filtering. And this takes precedence.

can we not represent a.com cell as + -
this would help the users greatly in depicting if the requests are really allowed or blocked, if one is using more and more dynamic url filtering rules?

Note: Sorry, i am just trying to understand. If it is not meaningful and feasible. We can leave this here..

@g3939434
Copy link

can we not represent a.com cell as + -

Your example isn't that good. It already reflected on the UI with + - and in yellow. The real problem is when handling the noop rule. Noop rule is counted as blocked.

@harshanvn
Copy link
Author

It already reflected on the UI with + - and in yellow.

Actually, i was referring to this one
ublock url filtering in ui

@g3939434
Copy link

That is the problem of noop rule. The only request from ajax.googleapis.com was that jquery.min.js. And a loop rule (I assumed) should count as nothing but now count as blocked. So it only showed with - and inred. But I assumed it should show with + and in green.

You can test your case in real situation when the requests from same domain have more than one request. One request is blocked by a.com and other one is allowed by a.com/url

a.com/ - block rule based on dynamic filtering setting
a.com/url - allow rule based on dynamic url filtering. And this takes precedence.

It would become + - and in yellow.

With only one request and blocked by a.com should be red and -
With only one request and allowed by a.com/url (blocked by a.com) should be green and +

@gorhill
Copy link
Owner

gorhill commented Jul 10, 2015

I am getting lost in the issues here. The one in OP is not an issue, it is by design.

The new one added to this issue, it looks like I have misinterpreted it. (I thought you expected the cell to be shaded dark gray).

This one is unexpected, unless there was a request blocked for ajax.googleapis.com. Can you please give URL etc. on how to reproduce? never mind for the test case, I am inferring http://phoronix.com/scan.php?page=home from the matrix.

@g3939434
Copy link

@gorhill

Ok Thanks. Submitted #476

@gorhill
Copy link
Owner

gorhill commented Jul 10, 2015

Ah ok, I had missed this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants