Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deb): dpkg-sig format #841

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

KSpaceer
Copy link
Contributor

@KSpaceer KSpaceer commented Jul 9, 2024

Closes #840

Applying hex-encoding to MD5 and SHA1 hashes in dpkg-sig signing method, adding newlines between single file lines.

Verifying digests in dpkg-sig unit testing

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.15%. Comparing base (d33a923) to head (779b2e0).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/sign/pgp.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   73.12%   73.15%   +0.03%     
==========================================
  Files          22       22              
  Lines        2489     2492       +3     
==========================================
+ Hits         1820     1823       +3     
  Misses        463      463              
  Partials      206      206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 changed the title Dpkg sig fix fix(deb): dpkg-sig format Jul 9, 2024
@caarlos0
Copy link
Member

caarlos0 commented Jul 9, 2024

awesome find! many thanks 🙏

@caarlos0 caarlos0 merged commit b3e7ff9 into goreleaser:main Jul 9, 2024
46 of 47 checks passed
@github-actions github-actions bot added this to the 2.38.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid dpkg-sig file
2 participants